Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make check broken on windows #5226

Closed
brson opened this issue Mar 4, 2013 · 2 comments
Closed

make check broken on windows #5226

brson opened this issue Mar 4, 2013 · 2 comments
Labels
O-windows Operating system: Windows
Milestone
0.6

Comments

@brson
Copy link
Contributor

brson commented Mar 4, 2013

I've heard from a few people that make check no longer works on windows, with the license check failing.
@catamorphism
Copy link
Contributor

Tested on Windows, worked fine. Reopen if anyone can give specific steps to reproduce.

@catamorphism
Copy link
Contributor

Tested on Windows, 'make tidy' worked fine. Reopen if anyone can give specific steps to reproduce.

oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
@flip1995
Rollup merge of rust-lang#5226 - ThibsG:DerefExplicit1566, r=flip1995
3481bf4 
Add lint for explicit deref and deref_mut method calls

This PR adds the lint `explicit_deref_method` that suggests replacing `deref()` and `deref_mut()` with `&*a` and `&mut *a`.

It doesn't lint inside macros.

This PR is the continuation of  rust-lang#3258.

changelog: Add lint `explicit_deref_method`.

Fixes: rust-lang#1566
oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5470 - flip1995:rollup-cvkuiza, r=flip1995
6651c1b 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#5226 (Add lint for explicit deref and deref_mut method calls)
 - rust-lang#5248 (Add lint on large non scalar const)
 - rust-lang#5430 (Disallow bit-shifting in integer_arithmetic)
 - rust-lang#5466 (large_enum_variant: Report sizes of variants)
 - rust-lang#5468 (Zero single char names)

Failed merges:

r? @ghost

changelog: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-windows Operating system: Windows
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@brson @catamorphism