Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incr.comp.: Querify WF-checking so it can be cached #46753

Closed
michaelwoerister opened this issue Dec 15, 2017 · 1 comment
Closed

incr.comp.: Querify WF-checking so it can be cached #46753

michaelwoerister opened this issue Dec 15, 2017 · 1 comment
Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@michaelwoerister
Copy link
Member

At the moment WF checking is not done via a query. As a consequence, we cannot cache it during incremental compilation. Seems like an easy optimization.

cc @nikomatsakis
@michaelwoerister michaelwoerister added A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Dec 15, 2017
@michaelwoerister michaelwoerister mentioned this issue Jan 22, 2018
Open
32 tasks
@wesleywiser
Copy link
Member

I'm working on this.

wesleywiser added a commit to wesleywiser/rust that referenced this issue Mar 11, 2018
@wesleywiser
Remove unused fields
c192523 
Related to rust-lang#46753
wesleywiser added a commit to wesleywiser/rust that referenced this issue Mar 11, 2018
@wesleywiser
Queryify check_item_well_formed
5dfb4bb 
Fixes rust-lang#46753
wesleywiser added a commit to wesleywiser/rust that referenced this issue Mar 11, 2018
@wesleywiser
Queryify check_trait_item_well_formed
25baba1 
Fixes rust-lang#46753
wesleywiser added a commit to wesleywiser/rust that referenced this issue Mar 11, 2018
@wesleywiser
Queryify check_impl_item_well_formed
2b3d2a5 
Fixes rust-lang#46753
wesleywiser added a commit to wesleywiser/rust that referenced this issue Mar 16, 2018
@wesleywiser
Remove unused fields
450d35f 
Related to rust-lang#46753
wesleywiser added a commit to wesleywiser/rust that referenced this issue Mar 16, 2018
@wesleywiser
Queryify check_trait_item_well_formed
edbd02f 
Fixes rust-lang#46753
wesleywiser added a commit to wesleywiser/rust that referenced this issue Mar 16, 2018
@wesleywiser
Queryify check_impl_item_well_formed
4f1f389 
Fixes rust-lang#46753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wesleywiser @michaelwoerister