Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ascii::escape_default to core for no_std support #46409

Closed
ameets opened this issue Nov 30, 2017 · 2 comments
Closed

Move ascii::escape_default to core for no_std support #46409

ameets opened this issue Nov 30, 2017 · 2 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ameets
Copy link

ameets commented Nov 30, 2017

It sounds like AsciiExt's methods have been largely moved to individual types, which is great. Would it be possible to move ascii::escape_default (escaped version of u8) to core?

Reference: https://internals.rust-lang.org/t/std-ascii-in-core/6263/7
@frewsxcv frewsxcv added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 5, 2017
@XAMPPRocky XAMPPRocky added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Feb 26, 2018
@1011X 1011X mentioned this issue Mar 4, 2018
Merged
bors added a commit that referenced this issue Mar 13, 2018
@bors
Auto merge of #48735 - 1011X:master, r=alexcrichton
c290857 
Move ascii::escape_default to libcore

As requested in #46409, the `ascii::escape_default` method has been added to the core library. All I did was copy over the `std::ascii` module file, remove the (redundant) `AsciiExt` trait, and change some of the documentation to match. None of the tests were changed.

I wasn't sure how to handle the annotations. For `EscapeDefault` and `escape_default()`, I changed them to `#[unstable(feature = "core_ascii", issue = "46409")]`. Is that alright? Or should I leave them as they were?
@Phlosioneer
Copy link
Contributor

Triage: #48735 seems to have addressed this?

@SimonSapin
Copy link
Contributor

Yes it has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@SimonSapin @frewsxcv @XAMPPRocky @Phlosioneer @ameets