Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable debuginfo-gdb tests where GDB can't cope #38948

Closed
nrc opened this issue Jan 9, 2017 · 7 comments
Closed

Disable debuginfo-gdb tests where GDB can't cope #38948

nrc opened this issue Jan 9, 2017 · 7 comments
Assignees
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@nrc
Copy link
Member

nrc commented Jan 9, 2017

For versions of GDB recent enough to support Rust we run gdb tests, however, for the versions of GDB distributed with Ubuntu 16.10 and 17.4, there are bugs in the support which cause our tests to fail. We should detect the version of GDB and not run the tests if they will fail.

cc @michaelwoerister @Manishearth

@nrc nrc added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc labels Jan 9, 2017
@michaelwoerister
Copy link
Member

@nrc I've noted your GDB version as 7.11.90, do you know the other one?

@nrc
Copy link
Member Author

nrc commented Jan 9, 2017

Failing tests:

failures:
    [debuginfo-gdb] debuginfo-gdb/borrowed-enum.rs
    [debuginfo-gdb] debuginfo-gdb/generic-struct-style-enum.rs
    [debuginfo-gdb] debuginfo-gdb/generic-tuple-style-enum.rs
    [debuginfo-gdb] debuginfo-gdb/packed-struct.rs
    [debuginfo-gdb] debuginfo-gdb/recursive-struct.rs
    [debuginfo-gdb] debuginfo-gdb/struct-in-enum.rs
    [debuginfo-gdb] debuginfo-gdb/struct-style-enum.rs
    [debuginfo-gdb] debuginfo-gdb/tuple-style-enum.rs
    [debuginfo-gdb] debuginfo-gdb/union-smoke.rs
    [debuginfo-gdb] debuginfo-gdb/unique-enum.rs

I'm afraid I only know that version number. Maybe we should just disable for < 8 ?

@michaelwoerister
Copy link
Member

I've just had a related report by exi on IRC: https://absolute.fail/rust-debuginfo-test.txt
GDB version is GNU gdb (GDB) 7.12, failing tests are:

failures:
    [debuginfo-gdb] debuginfo-gdb/borrowed-enum.rs
    [debuginfo-gdb] debuginfo-gdb/generic-struct-style-enum.rs
    [debuginfo-gdb] debuginfo-gdb/generic-tuple-style-enum.rs
    [debuginfo-gdb] debuginfo-gdb/packed-struct.rs
    [debuginfo-gdb] debuginfo-gdb/recursive-struct.rs
    [debuginfo-gdb] debuginfo-gdb/struct-in-enum.rs
    [debuginfo-gdb] debuginfo-gdb/struct-style-enum.rs
    [debuginfo-gdb] debuginfo-gdb/tuple-style-enum.rs
    [debuginfo-gdb] debuginfo-gdb/union-smoke.rs
    [debuginfo-gdb] debuginfo-gdb/unique-enum.rs

@michaelwoerister
Copy link
Member

Maybe we should just disable for < 8 ?

I'd like to keep the range of disabled versions as small as possible.

@Manishearth
Copy link
Member

8.0 is the first version in which it will be fixed (the next gdb release)

We should also make sure the version matching allows a non-release (local build)

@michaelwoerister
Copy link
Member

We should also make sure the version matching allows a non-release (local build)

Any idea how to do that?

@Manishearth
Copy link
Member

GNU gdb (GDB) 7.12.50.20161215-git is what my local version says. I guess it needs -git in the version

@michaelwoerister michaelwoerister self-assigned this Jan 13, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jan 19, 2017
…, r=nrc

debuginfo: Ignore optimized enum tests for GDB versions that can't handle them.

Fixes rust-lang#38948.

r? @nrc
cc @Manishearth
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 5, 2017
ignore more gdb versions with buggy rust support

This extends the versions of gdb which were ignored in rust-lang#39039. While just ignoring gdb versions up to 7.12.1 would have been sufficient for now, I believe (after consulting https://sourceware.org/gdb/wiki/Internals%20Versions)  that ignoring versions up to 7.12.9 will prevent the tests failing again for 7.12.2, etc. while still running all tests for the development versions of gdb (which will be >= 7.12.10 as far as I can tell).

This should fix rust-lang#39522.

cc @Manishearth, @michaelwoerister, rust-lang#38948
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 5, 2017
ignore more gdb versions with buggy rust support

This extends the versions of gdb which were ignored in rust-lang#39039. While just ignoring gdb versions up to 7.12.1 would have been sufficient for now, I believe (after consulting https://sourceware.org/gdb/wiki/Internals%20Versions)  that ignoring versions up to 7.12.9 will prevent the tests failing again for 7.12.2, etc. while still running all tests for the development versions of gdb (which will be >= 7.12.10 as far as I can tell).

This should fix rust-lang#39522.

cc @Manishearth, @michaelwoerister, rust-lang#38948
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 5, 2017
ignore more gdb versions with buggy rust support

This extends the versions of gdb which were ignored in rust-lang#39039. While just ignoring gdb versions up to 7.12.1 would have been sufficient for now, I believe (after consulting https://sourceware.org/gdb/wiki/Internals%20Versions)  that ignoring versions up to 7.12.9 will prevent the tests failing again for 7.12.2, etc. while still running all tests for the development versions of gdb (which will be >= 7.12.10 as far as I can tell).

This should fix rust-lang#39522.

cc @Manishearth, @michaelwoerister, rust-lang#38948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

3 participants