Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::num::Wrapping does not implement std::fmt::Display #33006

Closed
Thiez opened this issue Apr 15, 2016 · 1 comment
Closed

std::num::Wrapping does not implement std::fmt::Display #33006

Thiez opened this issue Apr 15, 2016 · 1 comment

Comments

@Thiez
Copy link
Contributor

Thiez commented Apr 15, 2016

I would expect this to work, and print '1': println!("{}", std::num::Wrapping(1u8));. Instead the compiler informs me:

error: the trait core::fmt::Display is not implemented for the type core::num::Wrapping<u8>

Perhaps Wrapping should implement Display?
@alexcrichton
Copy link
Member

Sounds like a good idea to me!

tbu- added a commit to tbu-/rust that referenced this issue Apr 16, 2016
@tbu-
Implement Display and Hash for std::num::Wrapping
79e68a6 
Also, change the `Debug` implementation to only show the inner value.

Fixes rust-lang#33006.
@tbu- tbu- mentioned this issue Apr 16, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 17, 2016
@Manishearth
Rollup merge of rust-lang#33023 - tbu-:pr_wrapping_traits, r=alexcric…
5fc8065 
…hton

Implement `Display` and `Hash` for `std::num::Wrapping`

Also, change the `Debug` implementation to only show the inner value.

Fixes rust-lang#33006.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @Thiez