Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change extern foo = "bar" to extern "bar" as foo #16608

Closed
pcwalton opened this issue Aug 19, 2014 · 2 comments
Closed

Change extern foo = "bar" to extern "bar" as foo #16608

pcwalton opened this issue Aug 19, 2014 · 2 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries
Milestone
1.0

Comments

@pcwalton
Copy link
Contributor

Per the RFC.

Nominating for 1.0, P-backcompat-lang.
@pnkfelix
Copy link
Member

P-backcompat-lang, 1.0.

@pnkfelix pnkfelix added this to the 1.0 milestone Aug 28, 2014
@huonw
Copy link
Member

huonw commented Sep 6, 2014

Fixed by #16923.

@huonw huonw closed this as completed Sep 6, 2014
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Mar 10, 2024
@bors
Auto merge of rust-lang#16723 - norskeld:constants-autocomplete, r=Ve…
518cfe8 
…ykril

fix: autocomplete constants inside format strings

Hi! This PR adds autocompletion for constants (including statics) inside format strings and closes rust-lang#16608.

I'm not sure about adding the `constants` field to the `CompletionContext`. It kinda makes sense, since it's in line with the `locals` field, and this way everything looks a bit cleaner, but at the same time does it really need to be there?

Anyway, let me know if anything should/can be changed. :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
4 participants
@alexcrichton @pcwalton @pnkfelix @huonw