Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model lexer is still wrong #15883

Closed
2 of 7 tasks
emberian opened this issue Jul 21, 2014 · 2 comments · Fixed by #24620
Closed
2 of 7 tasks

Model lexer is still wrong #15883

emberian opened this issue Jul 21, 2014 · 2 comments · Fixed by #24620
Labels
A-grammar Area: The grammar of Rust metabug Issues about issues themselves ("bugs about bugs")

Comments

@emberian
Copy link
Member

Tracking issue for all known problems with the lexer.

Todo:
@emberian emberian self-assigned this Jul 21, 2014
@emberian emberian mentioned this issue Jul 23, 2014
Closed
@fhahn fhahn mentioned this issue Dec 26, 2014
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Dec 30, 2014
@alexcrichton
rollup merge of rust-lang#20245: fhahn/make-lexer-tests-runable-again
6fabf42 
I would like to look into some issues related to the model lexer  rust-lang#15883.

I stumbled upon 2 minor problems when I tried running the lexer tests:

* antlr did not put the generated files in the correct directory
* grammer/verify.rs did not work with the most recent version of rust

With these changes (and setting CLASSPATH=/usr/share/java/antlr-4.4-complete.jar:$CLASSPATH) I was able to execute the tests.

Note that I just fixed the syntax errors and added `None` as 2. argument of `Literal`. I am not sure if this is correct however. I still have to take a closer look at what verify.rs actually does. Are there any helpful pointers?
@fhahn fhahn mentioned this issue Jan 5, 2015
Merged
@fhahn
Copy link
Contributor

fhahn commented Feb 4, 2015

Does it stilll make sense to keep the antlr lexer after the flex/bison parser was added in #21452 ?

@emberian
Copy link
Member Author

emberian commented Feb 4, 2015

I initially wrote this lexer to serve as the reference because it is far simpler than the flex one.

@emberian emberian removed their assignment Mar 26, 2015
@fhahn fhahn mentioned this issue Apr 10, 2015
Closed
@pczarn pczarn mentioned this issue Apr 20, 2015
Merged
bors added a commit that referenced this issue Apr 21, 2015
@bors
Auto merge of #24620 - pczarn:model-lexer-issues, r=cmr
7397bdc 
Fixes #15679
Fixes #15878
Fixes #15882
Closes #15883
@carols10cents carols10cents mentioned this issue May 5, 2015
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue May 7, 2015
@steveklabnik
Rollup merge of rust-lang#25137 - carols10cents:fix-token-declaration…
872132f 
…, r=alexcrichton

I know this is the most trivial thing since it's *just* the model lexer, not the real lexer, but [it is simpler to read](rust-lang#15883 (comment)) and it'd be great if it was up to date but [it's been rotting](rust-lang#22379) and this is a tiny bit of that.

Thanks!!!!!!
steveklabnik added a commit to steveklabnik/rust that referenced this issue May 7, 2015
@steveklabnik
Rollup merge of rust-lang#25137 - carols10cents:fix-token-declaration…
42212bb 
…, r=alexcrichton

I know this is the most trivial thing since it's *just* the model lexer, not the real lexer, but [it is simpler to read](rust-lang#15883 (comment)) and it'd be great if it was up to date but [it's been rotting](rust-lang#22379) and this is a tiny bit of that.

Thanks!!!!!!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-grammar Area: The grammar of Rust metabug Issues about issues themselves ("bugs about bugs")
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Model lexer: Fix remaining issues pczarn/rust
2 participants
@fhahn @emberian