-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run-make -Zbuild-std
tests fail on compiler_builtins
on older branches
#130634
Comments
We should probably add a test using the beta compiler to the |
We could also add running the beta compiler with |
I think this kind of thing would also be an issue once we get to the stable promotion. I don't know if |
I'm very surprised there isn't a lockfile being used here. Does -Zbuild-std not use one automatically? Should be modify the tests to cp in the one from library/Cargo.lock? |
well at least now libstd has its own lockfile, so that makes things easier. |
Those run-make tests are using stage0 cargo, which is 1.81.0 on the beta branch, and @weihanglo pointed out that this version doesn't have the logic to find the relatively new Maybe run-make should always use the current stage's cargo as a prereq? (i.e. the same stage as |
Definitely. I thought using bootstrap cargo was sus when I wrote that but I had already spent a lot of time trying to get any cargo to run. |
Yes, I should've done that even if bootstrap cargo somehow worked |
Rollup merge of rust-lang#130642 - cuviper:run-make-cargo, r=jieyouxu Pass the current cargo to `run-make` tests A couple tests were using `BOOTSTRAP_CARGO` with `-Zbuild-std`, but that stage0 cargo might not always be in sync with in-tree changes. In particular, those tests started failing on the beta branch because the older cargo couldn't find the library `Cargo.lock`, and then couldn't build the latest version of `compiler_builtins` that had nightly changes. Fixes rust-lang#130634 r? `@saethlin`
I tried: merging backports on 1.82-beta (#130569)
I expected to see this happen: Test successful
Instead, this happened: The job
dist-various-1
failed!Both tests use
-Zbuild-std
and failed to buildcompiler_builtins v0.1.126
:Note that beta's
library/Cargo.lock
only hascompiler_builtins v0.1.123
, so it appears cargo isn't heeding that with-Zbuild-std
.arch::naked_asm!
was added in #130146 and started being used in rust-lang/compiler-builtins#686 for 0.1.126.To unblock beta, I'm going to add
//@ only-nightly
to those tests, as suggested on my PR, especially since-Zbuild-std
is unstable anyway. This particular failure shouldn't be an issue when the current nightlies are promoted to the next beta, but we should think about this kind of failure mode in the long term too.The text was updated successfully, but these errors were encountered: