Stable build of 1.66.0 fails due to 'missing miri'

[gco]

On Solaris 11 x86_64, from scratch stable builds of 1.66.0 from git fails with:

...
   Compiling opener v0.5.0
   Compiling toml v0.5.9
    Finished dev [unoptimized] target(s) in 1m 02s
Build completed successfully in 0:01:10
Building rustbuild
    Finished dev [unoptimized] target(s) in 2.25s
thread 'main' panicked at 'missing miri', install.rs:205:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Build completed unsuccessfully in 0:00:03
make: *** [Makefile:54: install] Error 1

A nightly build of the same tag completes successfully, as do stable and nightly builds of 1.65.0.

[oli-obk]

Was there an earlier (nonfatal) error? If miri failed to build there should hopefully be a reason mentioned.

We turned miri on unconditionally, so builds require it to build successfully. Maybe we should disable that requirement for stable builds,but even so, stable builds should work just like nightly builds for miri

[mati865]

It doesn't even try to build miri, instead rustbuild panics soon after its start: https://github.com/msys2/MINGW-packages/actions/runs/3716308024/jobs/6302486421
Dunno about Solaris build but MSYS2 hack quite a lot patches that theoretically could cause problems.

[oli-obk]

Found the culprit: https://github.com/rust-lang/rust/blob/master/src/bootstrap/dist.rs#L1230

Should be easy enough to fix by making install not unwrap anymore. Looks like I was too eager

[etna]

Glad to see that this is indeed a real issue. Was tearing my hair out for hours wondering WHY x.py install kept failing with missing miri when config.toml is set with channel = "stable"

[paulmenzel]

We are still seeing this with 1.66.1.

    […]
       Compiling thiserror v1.0.33
        Finished release [optimized] target(s) in 38.48s
    warning: x.py has made several changes recently you may want to look at   
    help: consider looking at the changes in `src/bootstrap/CHANGELOG.md`
    note: to silence this warning, add `changelog-seen = 2` at the top of `config.toml`
    note: this message was printed twice to make it more likely to be seen
    Build completed successfully in 0:28:41
    + python3 ./x.py install
    Building rustbuild
        Finished dev [unoptimized] target(s) in 0.66s
    warning: x.py has made several changes recently you may want to look at   
    help: consider looking at the changes in `src/bootstrap/CHANGELOG.md`
    note: to silence this warning, add `changelog-seen = 2` at the top of `config.toml`
    thread 'main' panicked at 'missing miri', install.rs:205:14
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
    Build completed unsuccessfully in 0:00:01

[mati865]

The fix has been merged for the future 1.68 release.