Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: json output failure #10115

Closed
klutzy opened this issue Oct 28, 2013 · 2 comments
Closed

rustdoc: json output failure #10115

klutzy opened this issue Oct 28, 2013 · 2 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@klutzy
Copy link
Contributor

klutzy commented Oct 28, 2013

$ cat vacant.rs
#[link(name = "vacant")]; #[crate_type = "lib"];

$ rustdoc vacant.rs -w json
task '<unnamed>' failed at 'Rust generated JSON is invalid??',
/path/to/librustdoc/rustdoc.rs:319

Any library with no #[no_std] causes the failure.
This is because rustdoc::clean::Crate contains externs: HashMap<ast::CrateNum, ExternalCrate> so output is like {1: (...), 2: (...)}.

@chris-morgan
Copy link
Member

I can't get JSON output to work at all. A truly minimal test case in the current syntax is:

#[crate_id = "foo"];
$ rustdoc -w json foo.rs
task '<main>' failed at 'Rust generated JSON is invalid??', /home/chris/vc/rust/src/librustdoc/lib.rs:338

@emberian
Copy link
Member

cc me

flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 12, 2023
Move `mutex_atomic` to `restriction`

By rust-lang#4295, the general consensus seems to be that `mutex_atomic` is not a useful lint in most cases. If anything, it could be useful as a restriction on code that for whatever reason can't use atomics. Keeping it in `clippy::nursery` is harmful to people attempting to use clippy for soundness.

---

changelog: Moved [`mutex_atomic`] to `restriction`
[rust-lang#10115](rust-lang/rust-clippy#10115)
<!-- chnagelog_checked -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants