Skip to content

Commit

Permalink
auto merge of #11601 : dguenther/rust/fix_test_summary, r=brson
Browse files Browse the repository at this point in the history
The test run summary currently prints the wrong number of tests run. This PR fixes it by adding a newline to the log output, and also adds support for counting bench runs.

Closes #11381
  • Loading branch information
bors committed Jan 17, 2014
2 parents 93fb12e + 8f4edf9 commit 7d75bbf
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 10 deletions.
26 changes: 17 additions & 9 deletions src/etc/check-summary.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,30 @@
summaries = []
def summarise(fname):
summary = {}
fd = open(fname)
for line in fd:
status, test = line.strip().split(' ', 1)
if not summary.has_key(status):
summary[status] = []
summary[status].append(test)
summaries.append((fname, summary))
with open(fname) as fd:
for line in fd:
splitline = line.strip().split(' ')
if len(splitline) == 1:
continue
status = splitline[0]
test = splitline[-1]
# track bench runs
if splitline[1] == 'ns/iter':
status = 'bench'
if not summary.has_key(status):
summary[status] = []
summary[status].append(test)
summaries.append((fname, summary))
def count(t):
return sum(map(lambda (f, s): len(s.get(t, [])), summaries))
logfiles = sys.argv[1:]
map(summarise, logfiles)
ok = count('ok')
failed = count('failed')
ignored = count('ignored')
print "summary of %d test runs: %d passed; %d failed; %d ignored" % \
(len(logfiles), ok, failed, ignored)
measured = count('bench')
print "summary of %d test runs: %d passed; %d failed; %d ignored; %d measured" % \
(len(logfiles), ok, failed, ignored, measured)
print ""
if failed > 0:
print "failed tests:"
Expand Down
2 changes: 1 addition & 1 deletion src/libextra/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ impl<T: Writer> ConsoleTestState<T> {
match self.log_out {
None => (),
Some(ref mut o) => {
let s = format!("{} {}", match *result {
let s = format!("{} {}\n", match *result {
TrOk => ~"ok",
TrFailed => ~"failed",
TrIgnored => ~"ignored",
Expand Down

0 comments on commit 7d75bbf

Please sign in to comment.