Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
By default, jemalloc is building itself with -g3 if the local compiler supports it. It looks like this is generating a good deal of debug info that windows isn't optimizing out (on the order of 18MB). Windows gcc/ld is also not optimizing this data away, causing hello world to be 18MB in size. There's no current real need for debugging jemalloc to a great extent, so this commit manually passes -g1 to override -g3 which jemalloc is using. This is confirmed to drop the size of executables on windows back to a more reasonable size (2.0MB, as they were before). Closes #14144
- Loading branch information
161b50a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from cmr
at alexcrichton@161b50a
161b50a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/issue-14144 = 161b50a into auto
161b50a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/issue-14144 = 161b50a merged ok, testing candidate = bbd034c
161b50a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5807
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5805
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/4900
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4909
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5904
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4993
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/5001
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5907
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/4992
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4998
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/5060
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2793
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5900
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/4996
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/5011
161b50a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = bbd034c