Skip to content

Commit

Permalink
Update test for LF_BUILDINFO cl and cmd
Browse files Browse the repository at this point in the history
  • Loading branch information
nebulark committed Sep 10, 2024
1 parent 38e3a57 commit 153d877
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 19 deletions.
6 changes: 6 additions & 0 deletions src/tools/run-make-support/src/external_deps/llvm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ pub fn llvm_dwarfdump() -> LlvmDwarfdump {
LlvmDwarfdump::new()
}

/// Construct a new `llvm-pdbutil` invocation. This assumes that `llvm-pdbutil` is available
/// at `$LLVM_BIN_DIR/llvm-pdbutil`.
pub fn llvm_pdbutil() -> LlvmPdbutil {
LlvmPdbutil::new()
}

/// A `llvm-readobj` invocation builder.
#[derive(Debug)]
#[must_use]
Expand Down
4 changes: 4 additions & 0 deletions tests/run-make/pdb-buildinfo-cl-cmd/filecheck.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
CHECK: LF_BUILDINFO
CHECK: rustc.exe
CHECK: main.rs
CHECK: "-g" "--crate-name" "my_crate_name" "--crate-type" "bin" "-Cmetadata=dc9ef878b0a48666"
24 changes: 5 additions & 19 deletions tests/run-make/pdb-buildinfo-cl-cmd/rmake.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
//@ only-windows-msvc
// Reason: pdb files are unique to this architecture

use run_make_support::{assert_contains, bstr, env_var, rfs, rustc};
use run_make_support::{llvm, rustc};

fn main() {
rustc()
Expand All @@ -17,23 +17,9 @@ fn main() {
.crate_type("bin")
.metadata("dc9ef878b0a48666")
.run();
let tests = [
&env_var("RUSTC"),
r#""main.rs""#,
r#""-g""#,
r#""--crate-name""#,
r#""my_crate_name""#,
r#""--crate-type""#,
r#""bin""#,
r#""-Cmetadata=dc9ef878b0a48666""#,
];
for test in tests {
assert_pdb_contains(test);
}
}

fn assert_pdb_contains(needle: &str) {
let needle = needle.as_bytes();
use bstr::ByteSlice;
assert!(&rfs::read("my_crate_name.pdb").find(needle).is_some());
let pdbutil_result =
llvm::llvm_pdbutil().arg("dump").arg("-ids").input("my_crate_name.pdb").run();

llvm::llvm_filecheck().patterns("filecheck.txt").stdin_buf(pdbutil_result.stdout_utf8()).run();
}

0 comments on commit 153d877

Please sign in to comment.