Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax for asm! macro (RFC 2850) #410

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Syntax for asm! macro (RFC 2850) #410

merged 1 commit into from
Jun 11, 2020

Conversation

ayosec
Copy link
Contributor

@ayosec ayosec commented Jun 10, 2020

This patch adds support for the syntax added in rust-lang/rust#69171 for the asm! macro.

As an example, these screenshots show the difference in the highlight of the macro.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @da-x (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@da-x da-x merged commit 0d8ce07 into rust-lang:master Jun 11, 2020
@da-x
Copy link
Member

da-x commented Jun 11, 2020

Thanks!

@ayosec ayosec deleted the asm-macro branch June 11, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants