Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isize and usize types #28

Closed
wants to merge 2 commits into from
Closed

Add isize and usize types #28

wants to merge 2 commits into from

Conversation

loyd
Copy link

@loyd loyd commented Jan 9, 2015

@jhasse jhasse closed this in 24c5536 Jan 12, 2015
@jhasse
Copy link

jhasse commented Jan 12, 2015

Thanks! The .tmLanguage is generated using AAAPackageDev though. I've added your changes in the JSON file, too.

@brookst
Copy link

brookst commented Jan 12, 2015

When is it planned to remove the int/uint and i/u terms from this highlighter?

It was suggested to remove them immediately from the vim syntax highlighter (rust-lang/rust#20881), as this shows their deprecation.

Also, when does this get pushed up to github/linguist?

Thanks.

@jhasse
Copy link

jhasse commented Jan 12, 2015

Good idea. If someone opens a PR I will merge it right away, otherwise I
will do it in the following weeks ;)

Don't know about linguist. Are they using this plugin?

@brookst
Copy link

brookst commented Jan 12, 2015

Yeah, I got here from linguist. This plugin is linked as a submodule in https://github.com/github/linguist/tree/master/vendor/grammars. I assume that means githubs syntax highlighting is using this plugin.

I'm not a Sublime Text user, so I don't really want to start hacking at it without a way to test.

@loyd
Copy link
Author

loyd commented Jan 12, 2015

@jhasse I think we should wait a little bit, at least until the beta version of Rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants