New lint format_add_strings
#8626
Conversation
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
pitaj
force-pushed
the
format_add_string
branch
2 times, most recently
from
290b7d3
to
4d5103f
Compare
|
☔ The latest upstream changes (presumably #8594) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Changed to recommend |
|
☔ The latest upstream changes (presumably #8660) made this pull request unmergeable. Please resolve the merge conflicts. |
pitaj
force-pushed
the
format_add_string
branch
from
7771b3c
to
67badbe
Compare
|
Thanks! It will need another rebase, then it'll be ready to merge. Feel free to r+ it yourself @bors delegate+ |
|
✌️ @pitaj can now approve this pull request |
|
@llogiq why does it need another rebase? There are no conflicts. |
|
Maybe he missed your push? I'd say we let bors decide if this is ready or not. I don't want to steal your honer to use bors. You can merge this by commenting It looks like bors will merged this regardless of the inline code block... |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
New lint `format_add_strings` Closes #6261 changelog: Added [`format_add_string`]: recommend using `write!` instead of appending the result of `format!`
This comment was marked as outdated.
This comment was marked as outdated.
|
☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
@bors r=llogiq |
|
📌 Commit 67badbe has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Closes #6261
changelog: Added [
format_add_string]: recommend usingwrite!instead of appending the result offormat!