Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New lint is_digit_ascii_radix #8624

Merged
merged 1 commit into from
Apr 11, 2022
Merged

New lint is_digit_ascii_radix #8624

merged 1 commit into from
Apr 11, 2022

Conversation

pitaj
Copy link
Contributor

@pitaj pitaj commented Apr 2, 2022 •
edited
Loading

Closes #6399

changelog: Added [is_digit_ascii_radix]: recommend is_ascii_digit() or is_ascii_hexdigit() in place of is_digit(10) and is_digit(16)

@rust-highfive
Copy link

r? @xFrednet

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 2, 2022
@pitaj pitaj force-pushed the is_digit_ascii_radix branch 2 times, most recently from d33ff63 to 44c084b Compare April 3, 2022 00:30
xFrednet
xFrednet reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already looks good to me 👍 I've added two comments, and then it should be ready to be merged. 🙃

clippy_lints/src/methods/is_digit_ascii_radix.rs Outdated Show resolved Hide resolved
clippy_lints/src/methods/is_digit_ascii_radix.rs Outdated Show resolved Hide resolved
@xFrednet xFrednet added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Apr 4, 2022
@pitaj
Copy link
Contributor Author

pitaj commented Apr 5, 2022 •
edited
Loading

Done.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Apr 5, 2022
@bors
Copy link
Collaborator

bors commented Apr 6, 2022

☔ The latest upstream changes (presumably #8606) made this pull request unmergeable. Please resolve the merge conflicts.

@pitaj
Copy link
Contributor Author

pitaj commented Apr 7, 2022

Alright, moved the MSRV check and resolved the conflicts.

@xFrednet
Copy link
Member

xFrednet commented Apr 7, 2022 •
edited
Loading

Alright, the code looks good. Could you rebase your commit again on master? it looks like you accidentally pulled in a second commit from someone else 🙃

You're welcome to reach out, if you need help with that. Maybe you can also just use an interactive rebase and drop the other commit :)

@bors
Copy link
Collaborator

bors commented Apr 7, 2022

☔ The latest upstream changes (presumably #8646) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet
Copy link
Member

Hey @pitaj, thank you for the work!

(I've missed your push, that's why I'm only merging it now 😅)

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 11, 2022

📌 Commit 06cfeb9 has been approved by xFrednet

@bors
Copy link
Collaborator

bors commented Apr 11, 2022

⌛ Testing commit 06cfeb9 with merge dbcd828...

@bors
Copy link
Collaborator

bors commented Apr 11, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing dbcd828 to master...

@bors bors merged commit dbcd828 into rust-lang:master Apr 11, 2022
@bors bors mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xFrednet xFrednet xFrednet left review comments

Assignees

@xFrednet xFrednet

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint: is_ascii_digit instead of is_digit
5 participants
@pitaj @rust-highfive @bors @xFrednet @rustbot