fix needless_question_mark not considering async fn
#8311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
giraffate
reviewed
Jan 19, 2022
tests/ui/needless_question_mark.rs
Outdated
Comment on lines
130
to
133
| let _ = Some(3); | ||
| let _ = Some(3); | ||
| let _ = Some(3); | ||
| let _ = Some(3); |
dswij
force-pushed
the
8277
branch
2 times, most recently
from
caa3dd8
to
c233aea
Compare
|
Thank you! @bors r+ |
|
📌 Commit a052766 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8277
changelog: [
needless_question_mark] Fix FN on async functions