Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't suggest doc(hidden) or unstable variants in wildcard lint #7407

Merged
merged 4 commits into from
Jul 1, 2021
Merged

Don't suggest doc(hidden) or unstable variants in wildcard lint #7407

merged 4 commits into from
Jul 1, 2021

Commits on Jun 26, 2021

  1. Don't use exact definition of std's ErrorKind in test. 

    Every time we add something to this enum in std, this test breaks.
    @m-ou-se
    m-ou-se committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    3e59563 View commit details
    Browse the repository at this point in the history

  2. Don't suggest unstable and doc(hidden) variants.

    @m-ou-se
    m-ou-se committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    38569c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. Simplify wildcard_enum_match_arm test

    @flip1995
    flip1995 committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    0ffba7a View commit details
    Browse the repository at this point in the history

  2. match_wildcard_for_single_variants: don't produce bad suggestion 

    This fixes a bug where match_wildcard_for_single_variants produced a
bad suggestion where besides the missing variant, one or more hidden
variants were left.

This also adds tests to the ui-tests match_wildcard_for_single_variants
and wildcard_enum_match_arm to make sure that the correct suggestion is
produced.
    @flip1995
    flip1995 committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    fae7a09 View commit details
    Browse the repository at this point in the history