Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix needless_collect with binding shadowing #7289

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

camsteffen
Copy link
Contributor

changelog: Fix [needless_collect] weird output when a binding is shadowed

Fixes #7200

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 28, 2021
@Manishearth
Copy link
Member

@bors r+

huh, thought I'd reviewed this already. sorry!

@bors
Copy link
Collaborator

bors commented Jun 4, 2021

📌 Commit 21c829e has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Jun 4, 2021

⌛ Testing commit 21c829e with merge 9991040...

@bors
Copy link
Collaborator

bors commented Jun 4, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 9991040 to master...

@bors bors merged commit 9991040 into rust-lang:master Jun 4, 2021
@camsteffen camsteffen deleted the needless-collect-shadow branch July 8, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

needless_collect: spans are off by one
4 participants