Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle write!(buf, "\n") case better #7183

Merged
merged 1 commit into from
May 7, 2021
Merged

Conversation

th1000s
Copy link
Contributor

@th1000s th1000s commented May 6, 2021

Make write!(buf, "\n") suggest writeln!(buf) by removing
the trailing comma from writeln!(buf, ).

changelog: [write_with_newline] suggestion on only "\n" improved

Make `write!(buf, "\n")` suggest `writeln!(buf)` by removing
the trailing comma from `writeln!(buf, )`.

changelog: [`write_with_newline`] suggestion on only "\n" improved
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 6, 2021
@flip1995
Copy link
Member

flip1995 commented May 7, 2021

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented May 7, 2021

📌 Commit 5f3aae6 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented May 7, 2021

⌛ Testing commit 5f3aae6 with merge af8cf94...

@bors
Copy link
Collaborator

bors commented May 7, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing af8cf94 to master...

@bors bors merged commit af8cf94 into rust-lang:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants