Fix FN in iter_cloned_collect with a large array
#7138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
IMO it's generally super rare to be using a larger array so this is fine for now @bors r+ |
|
📌 Commit d7627dc has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6808
changelog: Fix FN in
iter_cloned_collectwith a large arrayI spotted that is_iterable_array function that
explicit_iter_looplint is using only works for array sizes <= 32.There is this comment:
I'm a bit confused, because I read that IntoIterator for arrays with const generic
Nis stable since = "1.0.0". Although Const Generics MVP were stabilized in Rust 1.51.Should I set MSRV for the current change? I will try to test with older compilers soon.