Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a minimal reproducer for the ICE in #6179 #6736

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

Y-Nak
Copy link
Contributor

@Y-Nak Y-Nak commented Feb 13, 2021

This PR is an auxiliary PR for #6179, just add a minimal reproducer for the ICE discussed in #6179.
See #6179 for more details.

changelog: none

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 13, 2021
@flip1995
Copy link
Member

NIT: Can you put this test in a separate file in the crashes/ dir? Normally we name them ice-<#PR/Issue>.rs and they usually don't have any output.

@Y-Nak Y-Nak force-pushed the reproducer-for-use_self-ice branch from 28f72a7 to 8d45c52 Compare February 13, 2021 16:18
@Y-Nak
Copy link
Contributor Author

Y-Nak commented Feb 13, 2021

Changes: Move the reproducer in crashes/.

@Y-Nak Y-Nak force-pushed the reproducer-for-use_self-ice branch from 8d45c52 to 87109bb Compare February 13, 2021 16:20
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Feb 13, 2021

📌 Commit 87109bb has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Feb 13, 2021

⌛ Testing commit 87109bb with merge 5f611ce...

@bors
Copy link
Collaborator

bors commented Feb 13, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 5f611ce to master...

@bors bors merged commit 5f611ce into rust-lang:master Feb 13, 2021
@Y-Nak Y-Nak deleted the reproducer-for-use_self-ice branch April 14, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants