Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggestion in manual_range_contains when using float #6320

Conversation

giraffate
Copy link
Contributor

Fix #6315

changelog: Fix suggestion in manual_range_contains when using float

@rust-highfive
Copy link

r? @flip1995

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 11, 2020
@giraffate giraffate force-pushed the fix_suggestion_in_manual_range_contains_using_float branch from 9fb266c to 5f64867 Compare November 11, 2020 13:45
@llogiq
Copy link
Contributor

llogiq commented Nov 14, 2020

Thank you! This is exactly what I would have written. 😀👍

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 14, 2020

📌 Commit 5f64867 has been approved by llogiq

@bors
Copy link
Collaborator

bors commented Nov 14, 2020

⌛ Testing commit 5f64867 with merge 408b615...

@bors
Copy link
Collaborator

bors commented Nov 14, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 408b615 to master...

@bors bors merged commit 408b615 into rust-lang:master Nov 14, 2020
@giraffate giraffate deleted the fix_suggestion_in_manual_range_contains_using_float branch November 14, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual RangeInclusive implementation needs a space when using floats.
5 participants