Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GraphQL in docs without backticks #5996

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Allow GraphQL in docs without backticks #5996

merged 2 commits into from
Sep 2, 2020

Conversation

Kestrer
Copy link
Contributor

@Kestrer Kestrer commented Sep 1, 2020

changelog: Allow "GraphQL" in [doc_markdown] without backticks.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ebroto (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 1, 2020
Copy link
Member

@ebroto ebroto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test in tests/ui/doc.rs, you can take a look at #3533 for an example.

@ebroto ebroto added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 1, 2020
@ebroto
Copy link
Member

ebroto commented Sep 2, 2020

@bors r+

Thanks, and feel free to take another issue if you wish, we have plenty of them :)

@bors
Copy link
Collaborator

bors commented Sep 2, 2020

📌 Commit 22c9940 has been approved by ebroto

@bors
Copy link
Collaborator

bors commented Sep 2, 2020

⌛ Testing commit 22c9940 with merge 7f27b12...

@bors
Copy link
Collaborator

bors commented Sep 2, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing 7f27b12 to master...

@bors bors merged commit 7f27b12 into rust-lang:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants