Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async test case for FP in wrong_self_convention lint #5934

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Aug 21, 2020

Closes: #4037

changelog: none

r? @ebroto

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 21, 2020
@ebroto
Copy link
Member

ebroto commented Aug 21, 2020

LGTM! Just needs a rebase after the rustup

On the other hand, bors merges with master to test so this should be fine (sorry, I'm new here 😅)

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 22, 2020

📌 Commit 03bc7ae has been approved by ebroto

@bors
Copy link
Collaborator

bors commented Aug 22, 2020

⌛ Testing commit 03bc7ae with merge a8520b0...

@bors
Copy link
Collaborator

bors commented Aug 22, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing a8520b0 to master...

@bors bors merged commit a8520b0 into rust-lang:master Aug 22, 2020
@ThibsG ThibsG deleted the WrongSelfTestCase4037 branch August 22, 2020 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong_self_convention false positive for async fn into_*
4 participants