cmp_owned: handle when PartialEq is not implemented symmetrically #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ghost
reviewed
Jun 10, 2020
ghost
reviewed
Jun 10, 2020
flip1995
added
S-waiting-on-author
|
I think I've addressed all of @mikerite's suggestions (thanks again). Besides reversing the operands when necessary, the lint will not erroneously suggest dereferencing when it's not implemented and catches some FN. |
ebroto
changed the title
flip1995
added
S-waiting-on-review
ebroto
force-pushed
the
4874_cmp_owned_fp
branch
from
f01d898
to
b498e1d
Compare
|
📌 Commit b498e1d has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Handle asymmetrical implementations of PartialEq in [
cmp_owned].Fixes #4874