Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend example for the unneeded_field_pattern lint #5541

Merged
merged 1 commit into from
May 8, 2020

Conversation

stanislav-tkach
Copy link
Contributor

Current example is incorrect (or pseudo-code) because a struct name is omitted. I have used the code from the tests instead. Perhaps this example can be made less verbose, but I think it is more convenient to see a "real" code as an example.


changelog: extend example for the unneeded_field_pattern lint

Current example is incorrect (or pseudo-code) because a struct name is omitted. I have used the code from the tests instead. Perhaps this example can be made less verbose, but I think it is more convenient to see a "real" code as an example.
@flip1995 flip1995 added the S-waiting-on-bors Status: The marked PR was approved and is only waiting bors label Apr 28, 2020
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phansch
Copy link
Member

phansch commented May 8, 2020

@bors r=flip1995

@bors
Copy link
Collaborator

bors commented May 8, 2020

📌 Commit 1afb6e6 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented May 8, 2020

⌛ Testing commit 1afb6e6 with merge ceddf34...

@bors
Copy link
Collaborator

bors commented May 8, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing ceddf34 to master...

@bors bors merged commit ceddf34 into rust-lang:master May 8, 2020
@stanislav-tkach stanislav-tkach deleted the patch-1 branch May 8, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants