More rustfix tests #4408
More rustfix tests #4408
Conversation
flip1995
added
the
S-waiting-on-review
phansch
force-pushed
the
more_rustfix_tests
branch
from
e3e42b8
to
a17ea1c
Compare
|
Had to run fmt for the |
|
Also added 582048c, which changes the suggestion of |
tests/ui/useless_attribute.stderr
Outdated
| | | ||
| LL | #[allow(dead_code)] | ||
| | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` | ||
| | | ||
| = note: `-D clippy::useless-attribute` implied by `-D warnings` | ||
|
|
||
| error: useless lint attribute | ||
| --> $DIR/useless_attribute.rs:7:1 | ||
| --> $DIR/useless_attribute.rs:8:1 |
There was a problem hiding this comment.
Does it also emit this suggestion if the attribute is not on top of the file? In that case, the suggestion would be wrong: Playground
There was a problem hiding this comment.
Yes it does :/ The following diff causes an incorrect suggestion:
diff --git a/tests/ui/useless_attribute.rs b/tests/ui/useless_attribute.rs
index c6fc5531..3b708dd9 100644
--- a/tests/ui/useless_attribute.rs
+++ b/tests/ui/useless_attribute.rs
@@ -1,5 +1,6 @@
// run-rustfix
// aux-build:proc_macro_derive.rs
+// aux-build:macro_rules.rs
#![warn(clippy::useless_attribute)]
#![warn(unreachable_pub)]
@@ -46,4 +47,7 @@ mod a {
pub use self::b::C;
}
+#[allow(dead_code)]
+extern crate macro_rules;
+
fn main() {}I wonder if we can detect if there have been any items before the attribute. If yes, then we should not trigger the lint.
There was a problem hiding this comment.
I'm going to try and use the items field of hir::Crate to check and see if the current item being checked is the first one. I'm not sure if that's the most reliable way, though 🤔
There was a problem hiding this comment.
Wait, items is a BTreeMap, so I'll have to check how/if that collection works wrt. sorting order 🤔
tests/ui/useless_attribute.fixed
Outdated
| extern crate clippy_lints; | ||
|
|
||
| #[macro_use] | ||
| extern crate proc_macro_derive; |
There was a problem hiding this comment.
Would it also emit the lint, when you add #[cfg_attr(..)] here?
There was a problem hiding this comment.
Not this particular case, because #[macro_use] with extern crate is whitelisted. It will trigger if it's changed like in the other diff, though. Both cases would be fixed by checking for previous items.
I removed the `Bar` static and `Foo` impl because they are not needed for what's tested here as far as I can tell.
The suggestion includes an 'errors' placeholder currently, so it's not `MachineApplicable`
This is now in line with the recommendations from here: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_errors/struct.Diagnostic.html#method.span_suggestion
phansch
force-pushed
the
more_rustfix_tests
branch
from
582048c
to
f416779
Compare
|
Since the |
|
I changed it to |
|
Thanks for the ping. I re-reviewed this yesterday, but forgot to approve 😄 @bors r+ |
|
📌 Commit eeeadf3 has been approved by |
More rustfix tests <!-- Thank you for making Clippy better! We're collecting our changelog from pull request descriptions. If your PR only updates to the latest nightly, you can leave the `changelog` entry as `none`. Otherwise, please write a short comment explaining your change. If your PR fixes an issue, you can add "fixes #issue_number" into this PR description. This way the issue will be automatically closed when your PR is merged. If you added a new lint, here's a checklist for things that will be checked during review or continuous integration. - [ ] Followed [lint naming conventions][lint_naming] - [ ] Added passing UI tests (including committed `.stderr` file) - [ ] `cargo test` passes locally - [ ] Executed `./util/dev update_lints` - [ ] Added lint documentation - [ ] Run `./util/dev fmt` [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints Note that you can skip the above if you are just opening a WIP PR in order to get feedback. Delete this line and everything above before opening your PR --> cc #3630 This is probably easier reviewed per-commit. changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
cc #3630
This is probably easier reviewed per-commit.
changelog: none