Fix float_cmp false positive when comparing signum #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 15, 2019 12:46
f1.signum() == f2.signum() f1.signum() != f2.signum() should not trigger a warning.
flip1995
reviewed
Jul 16, 2019
| @@ -493,6 +499,25 @@ fn is_allowed<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) -> bool { | |||
| } | |||
| } | |||
|
|
|||
| // Return true if `expr` is the result of `signum()` invoked on a float value. | |||
| fn is_signum(cx: &LateContext<'_, '_>, expr: &Expr) -> bool { | |||
| // The negation of a signum is still a signum | |||
There was a problem hiding this comment.
Nice, good catch!
Lint idea (for another PR):
// for
f1.signum() == -f2.signum()
// suggest
f1.signum() != f2.signum()Same goes for -sig==+sig and -sig==-sig and the != variants.
There was a problem hiding this comment.
Thanks! I'm not sure that's the best way to simplify f1.signum() == -f2.signum(), since if both f1 and f2 are 0, then also f1.signum() == f2.signum() == 0.
There was a problem hiding this comment.
Oh your right, in this case we can't really lint this. Never mind then :D
|
Thanks! @bors r+ |
|
📌 Commit 8a8eedf has been approved by |
bors
added a commit
that referenced
this pull request
Jul 16, 2019
Fix float_cmp false positive when comparing signum fixes #4248 changelog: Fix float_cmp false positive when comparing signum
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4248
changelog: Fix float_cmp false positive when comparing signum