Fix false positive in module_name_repetitions lint #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lint was triggering on modules inside expanded attrs, like for example `#[cfg(test)]` and possibly more.
phansch
commented
Apr 19, 2019
| @@ -1,3 +1,5 @@ | |||
| // compile-flags: --test | |||
There was a problem hiding this comment.
I couldn't find another attribute that caused this issue, that's why the --test is included here.
phansch
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 850c24e has been approved by |
bors
added a commit
that referenced
this pull request
Apr 20, 2019
Fix false positive in module_name_repetitions lint This lint was triggering on modules inside expanded attrs, like for example `#[cfg(test)]` and possibly more. It was not reporting a location in #3892 because `span.lo()` and `span.hi()` both were 0. Fixes #3892 changelog: Fix false positive in `module_name_repetitions` lint
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint was triggering on modules inside expanded attrs, like
for example
#[cfg(test)]and possibly more.It was not reporting a location in #3892 because
span.lo()andspan.hi()both were 0.Fixes #3892
changelog: Fix false positive in
module_name_repetitionslint