Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add machine applicable suggestion for bool_assert_comparison #10218

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Add machine applicable suggestion for bool_assert_comparison #10218

merged 1 commit into from
Jan 21, 2023

Conversation

Alexendoo
Copy link
Member

Fixes #7598
Also closes #8118, it had already been fixed by an earlier change but I've added a test for it

changelog: [bool_assert_comparison] The suggestion is now machine applicable

@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 21, 2023
dswij
dswij approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM. Thanks for this!

@dswij
Copy link
Member

dswij commented Jan 21, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 21, 2023

📌 Commit 5f49808 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 21, 2023

⌛ Testing commit 5f49808 with merge e0ee58b...

@bors
Copy link
Collaborator

bors commented Jan 21, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing e0ee58b to master...

@bors bors merged commit e0ee58b into rust-lang:master Jan 21, 2023
@Alexendoo Alexendoo deleted the bool-assert-comparison-suggestion branch January 21, 2023 19:41
@Alexendoo Alexendoo mentioned this pull request Feb 4, 2023
Merged
bors added a commit that referenced this pull request Feb 8, 2023
@bors
Auto merge of #10293 - Alexendoo:bool-assert-comparison-negation, r=d…
fd2d8be 
…swij

Negate suggestions when needed in `bool_assert_comparison`

changelog: none assuming this gets into the same release as #10218

Fixes #10291

r? `@dswij`

Thanks to `@black-puppydog` for spotting it early
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
4 participants
@Alexendoo @rustbot @dswij @bors