Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow UUID-style digit grouping #5431

Closed
Diggsey opened this issue Apr 7, 2020 · 1 comment · Fixed by #5451
Closed

Allow UUID-style digit grouping #5431

Diggsey opened this issue Apr 7, 2020 · 1 comment · Fixed by #5451
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy

Comments

@Diggsey
Copy link

Diggsey commented Apr 7, 2020

The lint "inconsistent-digit-grouping" should allow things that look like UUIDs, eg:

0xc43bbeba_12b6_4868_80bc_4bd324dbe4e1

And possibly other "common" number patterns.
@flip1995 flip1995 added good-first-issue These issues are a good way to get started with Clippy C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages labels Apr 8, 2020
@xyzd0
Copy link
Contributor

xyzd0 commented Apr 11, 2020

@rustbot claim

xyzd0 pushed a commit to xyzd0/rust-clippy that referenced this issue Apr 12, 2020
Allow UUID style formatting for inconsistent_digit_grouping lint
0dabe79 
This change adds a check to the `inconsistent_digit_grouping` to add a check for
NumericLiterals that follow the UUID format of 8-4-4-4-12.

If the NumericLiteral matches the UUID format, no further inconsistent grouping checks
will be performed.

Closes rust-lang#5431
@xyzd0 xyzd0 mentioned this issue Apr 12, 2020
Merged
bors added a commit that referenced this issue Apr 12, 2020
@bors
Auto merge of #5451 - xyzd:allow-uuid-format-digit-grouping, r=phansch
af5940b 
Allow UUID style formatting for `inconsistent_digit_grouping` lint

This change adds a check to the `inconsistent_digit_grouping` to add a check for
NumericLiterals that follow the UUID format of 8-4-4-4-12.

If the NumericLiteral matches the UUID format, no further inconsistent grouping checks
will be performed.

Closes #5431

changelog: Allow UUID style formatting for `inconsistent_digit_grouping` lint
@bors bors closed this as completed in a296058 Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow UUID style formatting for inconsistent_digit_grouping lint xyzd0/rust-clippy
3 participants
@Diggsey @flip1995 @xyzd0