Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a lint for find_map #3474

Closed
Eh2406 opened this issue Nov 30, 2018 · 2 comments
Closed

add a lint for find_map #3474

Eh2406 opened this issue Nov 30, 2018 · 2 comments
Labels
A-lint Area: New lints T-AST Type: Requires working with the AST

Comments

@Eh2406
Copy link

Eh2406 commented Nov 30, 2018

There are a bunch of iterator chains that are clearer with the new find_map. Off the top of my head, .find(_).map(_) and .filter_map(_).nex(). I think clippy should have a lit for this like the filter_map and filter_next lints.
@phansch phansch added T-AST Type: Requires working with the AST A-lint Area: New lints labels Dec 2, 2018
@andrehjr andrehjr mentioned this issue Apr 27, 2019
Merged
bors added a commit that referenced this issue Apr 30, 2019
@bors
Auto merge of #4039 - andrehjr:add-find-map-lints, r=flip1995
e56e325 
Add lints for find_map

changelog: adds lints for find_map and filter_map_next. Closes issue #3474

Hope I got everything correctly this time! Let me know if I missed something.
@flip1995 flip1995 mentioned this issue Jan 15, 2020
Closed
@basil-cow
Copy link
Contributor

@flip1995 this one is long implemented too. (Also, should I always tag you in those issues or there are more appropriate channels?)

@flip1995
Copy link
Member

Thanks! For Clippy I get notified for every comment/PR/issue/... anyway. Doesn't matter if I'm tagged or not.

I first look at the notifications I'm mentioned in though (if the list is long). Since these kind of issues are low hanging fruits, because I just have to click on close and give you a ❤️ for triage-ing, you can keep tagging me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints T-AST Type: Requires working with the AST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@phansch @Eh2406 @flip1995 @basil-cow