Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos + grammar #1037

Merged
merged 6 commits into from
Jul 26, 2021
Merged

Fix typos + grammar #1037

merged 6 commits into from
Jul 26, 2021

Commits on Jul 26, 2021

  1. minor grammar and typo fixes

    @kklibo @ehuss
    kklibo authored and ehuss committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    83f725f View commit details
    Browse the repository at this point in the history

  2. improve for loop description (copied from 'while let' equivalent)

    @kklibo @ehuss
    kklibo authored and ehuss committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    91b36e4 View commit details
    Browse the repository at this point in the history

  3. clean up grammar in 'slice types'

    @kklibo @ehuss
    kklibo authored and ehuss committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    5ae4a38 View commit details
    Browse the repository at this point in the history

  4. disambiguate sentence 

    The phrase 'may not' could mean 'might not' or 'is not allowed to'.
    @kklibo @ehuss
    kklibo authored and ehuss committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    e4833e4 View commit details
    Browse the repository at this point in the history

  5. disambiguate sentence 

    The original sentence could mean that "its destructor is run" and "it is dropped" are two separate possibilities, rather than two names for the same action.
    @kklibo @ehuss
    kklibo authored and ehuss committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    44bac0e View commit details
    Browse the repository at this point in the history

  6. Revert phrase change for destructors. 

    It is not clear if the original intended to mean these as two separate
concepts, or synonyms for the same thing.
    @ehuss
    ehuss committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    314567f View commit details
    Browse the repository at this point in the history