Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Implement migrations for RFC 2229 #35

Closed
3 tasks done
arora-aman opened this issue Jan 3, 2021 · 1 comment
Closed
3 tasks done

Implement migrations for RFC 2229 #35

arora-aman opened this issue Jan 3, 2021 · 1 comment
Labels
migrations
Milestone
Feature complete

Comments

@arora-aman
Copy link
Member

arora-aman commented Jan 3, 2021 •
edited
Loading

Details over here: https://hackmd.io/71qq-IOpTNqzMkPpAI1dVg?view#Migration-Plan
@arora-aman
Copy link
Member Author

For providing a suggestion:

  • If closure contains a block, then just add the let _ = (...) at the start of the block
  • else, add a { let _ = (...); at the start of the span and } at the end of the span as two separate suggestions.

Span suggestion examples:

@null-sleep null-sleep mentioned this issue May 4, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@bors
Auto merge of rust-lang#84152 - sexxi-goose:insignificant_dtor, r=nik…
b439be0 
…omatsakis

Insignificant destructors rfc 2229

- Adds new attribute `rustc_insignificant_dtor` to annotate the drop method.
- Adds a query to check if a type has a significant drop.
- Updates closure analysis to check for significant drops rather than just drop.

A type marked with the attribute `rustc_insignificant_dtor` is considered to not be significant. A drop is significant if it is implemented by the user or does anything that will have any observable behavior (other than freeing up memory).

rust-lang/project-rfc-2229#35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
migrations
Projects
None yet
Milestone
Feature complete
Development

No branches or pull requests
2 participants
@nikomatsakis @arora-aman