Fix avx512vbmi swizzle_dyn implementation #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvijdea-bd
force-pushed
the
fix-swizzle-dyn-vbmi
branch
from
166f12f
to
d5abbfa
Compare
|
Looks good to me! Thanks! FYI @workingjubilee |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With target_features = "avx512vbmi", swizzle_dyn with N = 32 did not set output lanes to 0 when the input index was out of range, because it used
_mm256_permutexvar_epi8(vpermb) which, unlike_mm256_shuffle_epi8(vpshufb), does not provide that behaviour.This PR fixes the problem and adds the avx512vbmi implementation for N = 64.