Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace 'locally built rustc' instructions by 'Miri in rustc' #2698

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

RalfJung
Copy link
Member

No description provided.


```sh
rm -f .auto-everything .auto-toolchain
./x.py test miri --stage 0
Copy link
Member

@saethlin saethlin Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this isn't mentioned in ./x.py test -h -v, it only lists src/tools/miri. Not sure if it is supposed to include just miri in that list. (I am just now learning I could have been running x test miri)

Copy link
Member Author

@RalfJung RalfJung Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only fairly recently learned about these shortcuts and honestly have no idea why they work... but they are handy.^^
@jyn514 is that something we can rely on even if it's not listed in --help?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 28, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 28, 2022

📌 Commit 75e040e has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 28, 2022

⌛ Testing commit 75e040e with merge 9622070...

@bors
Copy link
Collaborator

bors commented Nov 28, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 9622070 to master...

@bors bors merged commit 9622070 into rust-lang:master Nov 28, 2022
@RalfJung RalfJung deleted the miri-in-rustc branch December 2, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants