Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong EmulateByNameResult::NotSupported in syscall shim #1831

Merged
merged 1 commit into from Jun 11, 2021
Merged

Fix the wrong EmulateByNameResult::NotSupported in syscall shim #1831

merged 1 commit into from Jun 11, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2021

Without the change, the newly added test will fail with:

-thread 'main' panicked at 'unsupported Miri functionality: can't execute syscall with ID 0', $DIR/unsupported_syscall.rs:10:9
+thread 'main' panicked at 'unsupported Miri functionality: can't call foreign function: syscall', $DIR/unsupported_syscall.rs:10:9
 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

cc #1818 (comment)

@RalfJung
Copy link
Member

Thanks. :)
@bors r+

@bors
Copy link
Collaborator

bors commented Jun 11, 2021

📌 Commit 4f3718e has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented Jun 11, 2021

⌛ Testing commit 4f3718e with merge d39f0c6...

@bors
Copy link
Collaborator

bors commented Jun 11, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing d39f0c6 to master...

@bors bors merged commit d39f0c6 into rust-lang:master Jun 11, 2021
@ghost ghost deleted the emulate-by-name-result branch June 14, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants