Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the raw_entry API #23

Closed
thomcc opened this issue Nov 1, 2018 · 2 comments
Closed

Support for the raw_entry API #23

thomcc opened this issue Nov 1, 2018 · 2 comments

Comments

@thomcc
Copy link
Member

thomcc commented Nov 1, 2018

This isn't yet part of std::collections::HashMap's API, but has a number of features that cannot be done in the current API. It would be extremely nice if these could be done with hashbrown.

For background, see:

@Amanieu
Copy link
Member

Amanieu commented Nov 1, 2018

map.rs in hashbrown is pretty much a straight copy & paste of map.rs from the standard library, so porting raw_entry should be trivial.

Amanieu added a commit that referenced this issue Nov 27, 2018
@Amanieu
Copy link
Member

Amanieu commented Nov 27, 2018

There is a slight issue, see my comment.

Amanieu added a commit that referenced this issue Jan 14, 2019
bors bot added a commit that referenced this issue Jan 14, 2019
31: Add raw_entry + misc cleanups r=Amanieu a=Amanieu

This PR adds:
- The `raw_entry` API from std.
- Support for `#[may_dangle]` when the `nightly` feature is enabled.
- `HashMap` and `HashSet` tests from std.
- Misc code cleanups.
- `try_reserve`.
- Fixed variance on `IterMut`.

Fixes #23
Fixes #39 

Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
bors bot added a commit that referenced this issue Jan 14, 2019
31: Add raw_entry + misc cleanups r=Amanieu a=Amanieu

This PR adds:
- The `raw_entry` API from std.
- Support for `#[may_dangle]` when the `nightly` feature is enabled.
- `HashMap` and `HashSet` tests from std.
- Misc code cleanups.
- `try_reserve`.
- Fixed variance on `IterMut`.

Fixes #23
Fixes #39 

Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
@bors bors bot closed this as completed in #31 Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants