Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase minimal versions of libz-ng-sys and libz-sys to their latest releases. #424

Closed
wants to merge 1 commit into from
Closed

increase minimal versions of libz-ng-sys and libz-sys to their latest releases. #424

wants to merge 1 commit into from

Conversation

Byron
Copy link
Member

@Byron Byron commented Aug 23, 2024

That way, those compiling with -Zminimal-versions have higher chances of it to work.

See Byron/gitoxide#1541 for reference.

@Byron
increase minimal versions of libz-ng-sys and libz-sys to their la…
2ac52f0 
…test releases.

That way, those compiling with `-Zminimal-versions` have higher chances of it to work.

See Byron/gitoxide#1541 for reference.
@Byron Byron requested a review from jongiddy August 23, 2024 13:03
@Byron Byron marked this pull request as ready for review August 23, 2024 13:03
NobodyXu added a commit to NobodyXu/flate2-rs that referenced this pull request Aug 23, 2024
@NobodyXu
Fix msrv: Run msrv checks with minimal versions
227f358 
NobodyXu
Contributor
NobodyXu commented 3 hours ago
Since it is possible to for dependencies to bump MSRV in patch release, msrv checking should use the minimal versions supported by gix.

Users cares deeply about msrv can also pin them to the minimal versions to maintain their current msrv.

This would have also help discover bugs in rust-lang#424
@NobodyXu NobodyXu mentioned this pull request Aug 23, 2024
Merged
NobodyXu added a commit to NobodyXu/flate2-rs that referenced this pull request Aug 23, 2024
@NobodyXu
Fix msrv: Run msrv checks with minimal versions
6bdc32e 
Since it is possible to for dependencies to bump MSRV in patch release, msrv checking should use the minimal versions supported by gix.

Users cares deeply about msrv can also pin them to the minimal versions to maintain their current msrv.

This would have also help discover bugs in rust-lang#424
NobodyXu added a commit to NobodyXu/flate2-rs that referenced this pull request Aug 23, 2024
@NobodyXu
Fix msrv: Run msrv checks with minimal versions
387b9c6 
Since it is possible to for dependencies to bump MSRV in patch release, msrv checking should use the minimal versions supported by flate2.

Users cares deeply about msrv can also pin them to the minimal versions to maintain their current msrv.

This would have also help discover bugs in rust-lang#424
@Byron Byron marked this pull request as draft August 23, 2024 13:46
@Byron
Copy link
Member Author

Byron commented Aug 23, 2024

Plan is to put this commit into #425, and prep a new release from there.

@Byron
Copy link
Member Author

Byron commented Aug 23, 2024

Closing in favor of #425 .

@Byron Byron closed this Aug 23, 2024
@Byron Byron deleted the minimal-versions branch August 23, 2024 14:04
@jongiddy
Copy link
Contributor

I don't understand the problem here. Are earlier versions of these dependencies not working with flate2? I would not expect a library to need to raise versions unless it starts to use a new feature of the higher versions or, in some cases, to remove the possibility of using serious bugs discovered in earlier versions.

@Byron
Copy link
Member Author

Byron commented Aug 23, 2024 •
edited
Loading

The problem is that the versions specified in Cargo.toml are minimal versions that should be able to compile with a compiler at MSRV level.
However, when using -Zminimal-versions, it doesn't actually work, which is believed to be fix-worthy. I agree with that, even though it's not very common to operate on the lower bound of compatible dependency versions.

Edit: Admittedly, I didn't try what the actual minimal versions are. I just know that libz-ng fails on Windows if cc is too old. It's a new form of dependency hell if you ask me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongiddy jongiddy Awaiting requested review from jongiddy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Byron @jongiddy