Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bound on structs #104

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Remove bound on structs #104

merged 2 commits into from
Apr 20, 2017

Conversation

opilar
Copy link
Contributor

@opilar opilar commented Apr 17, 2017

Resolves #88

@alexcrichton alexcrichton mentioned this pull request Apr 18, 2017
Closed
@alexcrichton
Copy link
Member

Thanks for the PR! While you're at it would you mind updating a few methods as well?

Right now the constructors should require bounds like R: Read, but methods like get_ref, into_inner, etc ideally wouldn't Could you move those methods to a separate impl block without the bounds of R: Read?

If you're busy though please just let me know! I certainly don't mind merging this ahead of that :)

@opilar
Copy link
Contributor Author

opilar commented Apr 19, 2017 •
edited
Loading

@alexcrichton I hope I didn't miss anything. Where can I find some resources about using bounds properly? I've read articles about traits but nothing about this issue.

@alexcrichton alexcrichton merged commit ea990e1 into rust-lang:master Apr 20, 2017
@alexcrichton
Copy link
Member

Thanks for the PR! Looks great.

Right now this is mostly just a conventions issue in terms of where the bounds are located, but we shoudl have the conventions written up soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opilar @alexcrichton