Add __powitf2 symbol for f128 integer exponentiation
#614
Conversation
tgross35
changed the title
__powitf2 symbol for f128 powi__powitf2 symbol for f128 integer exponentation
tgross35
changed the title
__powitf2 symbol for f128 integer exponentation__powitf2 symbol for f128 integer exponentiation
This will unblock adding support to compiler_builtins (<rust-lang/compiler-builtins#614>), which will then unblock adding tests for these new functions.
This will unblock adding support to compiler_builtins (<rust-lang/compiler-builtins#614>), which will then unblock adding tests for these new functions.
|
Blocked until we have the function in libs, rust-lang/rust#125188 |
|
Lol @Qadeem411 I have to imagine you didn’t mean to approve this |
Add `powi` fo `f16` and `f128` This will unblock adding support to compiler_builtins (<rust-lang/compiler-builtins#614>), which will then unblock adding tests for these new functions.
tgross35
force-pushed
the
f16-f128-powi
branch
7 times, most recently
from
65841d8
to
9550d45
Compare
|
WIndows targets appear to fail compiling this crate because powi uses the f128 multiply and divide in its implementation, and these are not available. I don't know why only Windows has the issue, but other platforms without these available natively (e.g. aarch darwin) do not, must be slightly different linkage rules. How should I handle this @Amanieu? |
|
I think this just happens to work before libgcc provides these symbols, but that's not available on -msvc targets. You'll need to implement a fallback for that target for testing, at least temporarily. |
tgross35
force-pushed
the
f16-f128-powi
branch
3 times, most recently
from
fdb0fd1
to
241b9a8
Compare
|
It looks like I can make this work by recreating |
Add `powi` fo `f16` and `f128` This will unblock adding support to compiler_builtins (<rust-lang/compiler-builtins#614>), which will then unblock adding tests for these new functions.
tgross35
force-pushed
the
f16-f128-powi
branch
from
241b9a8
to
fbf79c0
Compare
Adds `__powitf2`.
tgross35
force-pushed
the
f16-f128-powi
branch
from
fbf79c0
to
f74817b
Compare
tgross35
force-pushed
the
f16-f128-powi
branch
from
61980c6
to
e5407f7
Compare
No description provided.