Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse # env-dep directives in dep-info files #8421

Merged
merged 6 commits into from
Jun 30, 2020
Merged

Parse # env-dep directives in dep-info files #8421

merged 6 commits into from
Jun 30, 2020

Commits on Jun 29, 2020

  1. Parse # env-dep directives in dep-info files 

    This commit updates Cargo's parsing of rustc's dep-info files to account
for changes made upstream in rust-lang/rust#71858. This means that if
`env!` or `option_env!` is used in crate files Cargo will correctly
rebuild the crate if the env var changes.

Closes rust-lang#8417
    @alexcrichton
    alexcrichton committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    f666b19 View commit details
    Browse the repository at this point in the history

  2. Filter env vars to check against

    @alexcrichton
    alexcrichton committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    784ea96 View commit details
    Browse the repository at this point in the history

  3. Get past internal test on CI

    @alexcrichton
    alexcrichton committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    6820015 View commit details
    Browse the repository at this point in the history

  4. Address review feedback

    @alexcrichton
    alexcrichton committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    643f12e View commit details
    Browse the repository at this point in the history

  5. Bump hashed metadata version

    @alexcrichton
    alexcrichton committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    a6bf36e View commit details
    Browse the repository at this point in the history

  6. Handle env var escaping

    @alexcrichton
    alexcrichton committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    0750a6f View commit details
    Browse the repository at this point in the history