Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cargo publish --host with cargo publish --index #4209

Merged
merged 3 commits into from
Jun 24, 2017
Merged

Replace cargo publish --host with cargo publish --index #4209

merged 3 commits into from
Jun 24, 2017

Conversation

natboehm
Copy link
Contributor

This change makes the command consistent with other versions with the same flag. cargo publish --host is still supported, currently marked as deprecated, or for reuse as mentioned in issue #4208.

Fixes #3797

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Looks great to me, thanks!

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

📌 Commit 78e64de has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

⌛ Testing commit 78e64de with merge 39ebce40f79dac824f5d51c2641dccdba20b09aa...

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

durka pushed a commit to durka/cargo that referenced this pull request Jun 23, 2017
@bors
Auto merge of rust-lang#4090 - jluner:master, r=alexcrichton
03c0a41 
Add error-chain errors.

Fixes rust-lang#4209

Convert CargoResult, CargoError into an implementation provided by error-chain. The previous is_human machinery is mostly removed; now errors are displayed unless of the Internal kind, verbose mode will print all errors.
@bors
Copy link
Collaborator

bors commented Jun 24, 2017

⌛ Testing commit 78e64de with merge 1f280eb0390551e4cb56181054fa747679879c6a...

@bors
Copy link
Collaborator

bors commented Jun 24, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Collaborator

bors commented Jun 24, 2017

⌛ Testing commit 78e64de with merge 568b23f...

bors added a commit that referenced this pull request Jun 24, 2017
@bors
Auto merge of #4209 - natboehm:add-index-flag, r=alexcrichton
568b23f 
Replace `cargo publish --host` with `cargo publish --index`

This change makes the command consistent with other versions with the same flag. `cargo publish --host` is still supported, currently marked as deprecated, or for reuse as mentioned in issue #4208.

Fixes #3797
@bors
Copy link
Collaborator

bors commented Jun 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 568b23f to master...

@bors bors merged commit 78e64de into rust-lang:master Jun 24, 2017
@fa7ca7 fa7ca7 mentioned this pull request Jun 24, 2017
Closed
@carols10cents carols10cents mentioned this pull request Jun 25, 2017
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 26, 2017
Merged
bors added a commit to rust-lang/rust that referenced this pull request Jun 26, 2017
@bors
Auto merge of #42916 - Mark-Simulacrum:update-cargo, r=alexcrichton
77931c2 
Update Cargo

Haven't run extensive tests locally (not really sure what to test) but this primarily pulls in minor changes: rust-lang/cargo#4215, rust-lang/cargo#4209, and rust-lang/cargo#4218. The last one fixes the flaky cargo test by ignoring it, which should unblock #42745 -- that's beta nominated.

r? @alexcrichton
@ashleygwilliams ashleygwilliams mentioned this pull request Jul 7, 2017
Closed
Deedasmi added a commit to Deedasmi/crates.io that referenced this pull request Sep 26, 2017
@Deedasmi
Update contribution guidelines to use --index
75dbb19 
Introduced in rust-lang/cargo#4209
@Deedasmi Deedasmi mentioned this pull request Sep 26, 2017
Merged
bors-voyager bot added a commit to rust-lang/crates.io that referenced this pull request Sep 28, 2017
@bors-voyager
Merge #1086
eb0f315 
1086: Update contribution guidelines to use --index r=carols10cents

Introduced in rust-lang/cargo#4209
@behnam behnam mentioned this pull request Oct 2, 2017
Merged
@heisen-li heisen-li mentioned this pull request Nov 26, 2021
Closed
@heisen-li heisen-li mentioned this pull request Dec 3, 2021
Merged
@jluner jluner mentioned this pull request Jun 1, 2017
Merged
@ehuss ehuss added this to the 1.20.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

--host flag wants registry index URL, not registry website host
5 participants
@natboehm @rust-highfive @alexcrichton @bors @ehuss