-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CommandType struct #3198
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Ah, looks like it's simpler just to store that dylib path in compilation to avoid passing it around. |
@@ -33,6 +33,10 @@ pub struct Compilation<'cfg> { | |||
/// Output directory for rust dependencies | |||
pub deps_output: PathBuf, | |||
|
|||
/// Library search path for compiler plugins and build scripts | |||
/// which have dynamic dependencies. | |||
pub plugins_dylib_path: PathBuf, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name's not really exciting :(
@bors: r+ Thanks! |
📌 Commit 7165bd5 has been approved by |
Remove CommandType struct This removes `CommandType` struct as well as `cargo_rustc::process` function. So now all process creation goes thorough methods of `Compilation`. This does change search path order from `util::dylib_path(), host_dylib_path()` to `host_dylib_path(), util::dylib_path()`, but I hope this is not a problem. This also uncovers the fact that `rustdoc` is run sometimes with and sometimes without `host_dylib_path`. Is this intentional?
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
This removes
CommandType
struct as well ascargo_rustc::process
function. So now all process creation goes thorough methods ofCompilation
.This does change search path order from
util::dylib_path(), host_dylib_path()
tohost_dylib_path(), util::dylib_path()
, but I hope this is not a problem.This also uncovers the fact that
rustdoc
is run sometimes with and sometimes withouthost_dylib_path
. Is this intentional?