-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(manifest): Update crate-types with cdylib
#3018
Conversation
Rust 1.11 now supports the `cdylib` crate-type, so added it to the list of options. Also added a link to the [Linkage](https://doc.rust-lang.org/reference.html#linkage) section in the Rust Reference manual which explains what the different crate types actually mean in practice....though right now it actually doesn't explain what a `cdylib` is, specifically. ;)
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
The available options are `dylib`, `rlib`, and `staticlib`. You should only use | ||
this option in a project. Cargo will always compile packages (dependencies) | ||
based on the requirements of the project that includes them. | ||
The available options are `dylib`, `rlib`, `staticlib`, and, as of Rust 1.11, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't generally make statements like "as of Rust version" in the docs, as the deployed ones are for the current version, and the right versions come with each version of the compiler.
Thanks so much! If we can just remove the wording about Rust 1.11, very happy to merge this. I had this on my personal "todo" list and now I don't have to! 😄 |
Done, thanks for quick feedback! :) |
@bors: r+ |
📌 Commit c3a2e78 has been approved by |
docs(manifest): Update crate-types with `cdylib` Rust 1.11 now supports the `cdylib` crate-type, so added it to the list of options. Also added a link to the [Linkage](https://doc.rust-lang.org/reference.html#linkage) section in the Rust Reference manual which explains what the different crate types actually mean in practice....though right now it actually doesn't explain what a `cdylib` is, specifically. ;)
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Rust 1.11 now supports the
cdylib
crate-type, so added it to the list of options.Also added a link to the Linkage section in the Rust Reference manual which explains what the different crate types actually mean in practice....though right now it actually doesn't explain what a
cdylib
is, specifically. ;)