Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to the packages lint table from the related workspace table #13057

Merged
merged 1 commit into from
Nov 28, 2023
Merged

docs: link to the packages lint table from the related workspace table #13057

merged 1 commit into from
Nov 28, 2023

Conversation

AlexTMjugador
Copy link
Contributor

@AlexTMjugador AlexTMjugador commented Nov 28, 2023

What does this PR try to resolve?

This PR makes the exact format and definition of the workspace lints table easier to discover. It also follows the style of the surrounding documentation, such as the section immediately before about the dependencies table, which cross-references related package table documentation.

How should we test and review this PR?

N/A

Additional information

N/A

@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2023
@AlexTMjugador AlexTMjugador changed the title docs: reference the packages lint table from the related workspace table docs: link the packages lint table from the related workspace table Nov 28, 2023
@AlexTMjugador AlexTMjugador changed the title docs: link the packages lint table from the related workspace table docs: link to the packages lint table from the related workspace table Nov 28, 2023
This makes the exact format and definition of the workspace `lints`
table easier to discover. It also follows the style of the surrounding
documentation, such as the section immediately before about the
`dependencies` table, which cross-references related package table
documentation.
@AlexTMjugador
Copy link
Contributor Author

I did a force-push to address a precision nitpick on the commit and PR titles, I hope that's okay!

@epage
Copy link
Contributor

epage commented Nov 28, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 28, 2023

📌 Commit cc4f651 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2023
@bors
Copy link
Collaborator

bors commented Nov 28, 2023

⌛ Testing commit cc4f651 with merge 26333c7...

@bors
Copy link
Collaborator

bors commented Nov 28, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 26333c7 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Nov 28, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 26333c7 to master...

@bors bors merged commit 26333c7 into rust-lang:master Nov 28, 2023
20 checks passed
@bors
Copy link
Collaborator

bors commented Nov 28, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2023
Update cargo

7 commits in 9b13310ca596020a737aaa47daa4ed9ff8898a2f..26333c732095d207aa05932ce863d850fb309386
2023-11-24 16:20:51 +0000 to 2023-11-28 20:07:39 +0000
- docs: link to the packages lint table from the related workspace table (rust-lang/cargo#13057)
- Add more doc comments for gc changes. (rust-lang/cargo#13055)
- docs: Provide pointers for MSRV (rust-lang/cargo#13056)
- Fixed typo in SemVer Compatibility documentation page (rust-lang/cargo#13054)
- refactor: use custom error instead of anyhow (rust-lang/cargo#13050)
- review and remove ignored tests in rustfix (rust-lang/cargo#13047)
- docs: add doc comments for rustfix (rust-lang/cargo#13048)

r? ghost
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2023
Rollup merge of rust-lang#118425 - weihanglo:update-cargo, r=weihanglo

Update cargo

7 commits in 9b13310ca596020a737aaa47daa4ed9ff8898a2f..26333c732095d207aa05932ce863d850fb309386
2023-11-24 16:20:51 +0000 to 2023-11-28 20:07:39 +0000
- docs: link to the packages lint table from the related workspace table (rust-lang/cargo#13057)
- Add more doc comments for gc changes. (rust-lang/cargo#13055)
- docs: Provide pointers for MSRV (rust-lang/cargo#13056)
- Fixed typo in SemVer Compatibility documentation page (rust-lang/cargo#13054)
- refactor: use custom error instead of anyhow (rust-lang/cargo#13050)
- review and remove ignored tests in rustfix (rust-lang/cargo#13047)
- docs: add doc comments for rustfix (rust-lang/cargo#13048)

r? ghost
@rustbot rustbot modified the milestone: 1.76.0 Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants