Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cargo library to 0.72.2 for CVE patches #12462

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Bump cargo library to 0.72.2 for CVE patches #12462

merged 5 commits into from
Aug 7, 2023

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Aug 7, 2023 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Aug 7, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Aug 7, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.71.0. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2023
@ehuss
Copy link
Contributor

ehuss commented Aug 7, 2023

I imagine there are going to need to be some backports to get CI passing. Can you identify how many will be needed?

@weihanglo
Copy link
Member Author

Wish we could have ##12181…

I'll ping you when ready :)

@rustbot rustbot added the A-git Area: anything dealing with git label Aug 7, 2023
@weihanglo
Copy link
Member Author

I guess that's it. Feel uncomfortable with nightly changes, especially internal_features stuff.

cc @ehuss

@weihanglo weihanglo requested a review from ehuss August 7, 2023 21:55
@ehuss
Copy link
Contributor

ehuss commented Aug 7, 2023

Those look fine to me, since they are mostly for tests which aren't important for publishing the library. The clone change seems harmless.

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 7, 2023

📌 Commit c7182e7 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2023
@bors
Copy link
Collaborator

bors commented Aug 7, 2023

⌛ Testing commit c7182e7 with merge 1a737af...

@bors
Copy link
Collaborator

bors commented Aug 7, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 1a737af to rust-1.71.0...

@bors bors merged commit 1a737af into rust-lang:rust-1.71.0 Aug 7, 2023
20 checks passed
@weihanglo weihanglo deleted the bump-cargo-version branch August 7, 2023 23:48
@ehuss ehuss added this to the 1.71.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss Awaiting requested review from ehuss

Assignees

@ehuss ehuss

Labels
A-git Area: anything dealing with git S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
6 participants
@weihanglo @rustbot @ehuss @bors @Noratrieb @fee1-dead