Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note to cargo logout that it does not revoke the token. #11919

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Mar 31, 2023

This adds a note to help emphasize that cargo logout does not "log out of the server", and suggests what to do if that is what you want.

Unfortunately getting the URL for a registry is not a simple operation, so for now it just gives a generic message for the non-crates.io case.

@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-interacts-with-crates.io Area: interaction with registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2023
@ehuss ehuss mentioned this pull request Mar 31, 2023
@epage
Copy link
Contributor

epage commented Mar 31, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 31, 2023

📌 Commit f393f96 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2023
@bors
Copy link
Collaborator

bors commented Mar 31, 2023

⌛ Testing commit f393f96 with merge e589a5f...

@bors
Copy link
Collaborator

bors commented Mar 31, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing e589a5f to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 31, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing e589a5f to master...

@bors
Copy link
Collaborator

bors commented Mar 31, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors bors merged commit e589a5f into rust-lang:master Mar 31, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 1, 2023
Update cargo

9 commits in 145219a9f089f8b57c09f40525374fbade1e34ae..0e474cfd7b16b018cf46e95da3f6a5b2f1f6a9e7
2023-03-27 01:56:36 +0000 to 2023-03-31 23:15:58 +0000
- Add delays to network retries. (rust-lang/cargo#11881)
- Add a note to `cargo logout` that it does not revoke the token. (rust-lang/cargo#11919)
- Sync external-tools JSON docs. (rust-lang/cargo#11918)
- Drop derive feature from serde in cargo-platform (rust-lang/cargo#11915)
- Disable test_profile test on windows-gnu (rust-lang/cargo#11916)
- src/doc/src/reference/build-scripts.md: a{n =>} benchmark target (rust-lang/cargo#11908)
- Documented working directory behaviour for `cargo test`, `cargo bench` and `cargo run` (rust-lang/cargo#11901)
- docs(contrib): Link to office hours doc (rust-lang/cargo#11903)
- chore: Upgrade to clap v4.2 (rust-lang/cargo#11904)
@ehuss ehuss added this to the 1.70.0 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-interacts-with-crates.io Area: interaction with registries S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants